[ 
https://issues.apache.org/jira/browse/JSPWIKI-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707787#action_12707787
 ] 

Andrew Jaquith commented on JSPWIKI-528:
----------------------------------------

I'm working on the remaining items. I've chosen to tackle this a little 
differently than the way Greg proposed, but the end results should be quite 
satisfactory for all parties. Will check these in soon (likely later today).

> Rationalise the use of Collections, particularly with regard to pages
> ---------------------------------------------------------------------
>
>                 Key: JSPWIKI-528
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-528
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Greg Kable
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: jspwiki-528-AbstractFilteredPlugin.patch, 
> jspwiki-528-AttachmentHandler.patch, jspwiki-528-ContentManager.patch, 
> jspwiki-528-LinkCollector.patch, jspwiki-528-SearchProviders.patch, 
> jspwiki-528-Weblog.patch, jspwiki-528-WikiEngine-771034.patch, 
> jspwiki-528-WikiEngine.patch, jspwiki-528-WikiPage.patch, 
> jspwiki-528-workflow.Step.patch
>
>
> Most of the APIs return Collection rather than a finer interface and in many 
> cases these collections are repeatedly repacked and resorted unnecessarily. I 
> will go through all APIs that return collections of pages and make them 
> return a finer interface - probably List for unordered collections and 
> SortedSet for ordered collections. This will make the use of these 
> collections much clearer for further development and give us some opportunity 
> for future optimisations.
> This is likely to be a very wide set of changes across lots of different 
> classes so I'll submit separate patches for each class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to