[
https://issues.apache.org/jira/browse/JSPWIKI-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Kable updated JSPWIKI-528:
-------------------------------
Attachment: jspwiki-528-Weblog.patch
Patch 5 - jspwiki-528-Weblog.patch
Changes to WeblogPlugin:
- Changed findBlogEntries to return a List instead of a Collection
- Added findBlogEntriesSorted which returns a SortedSet in reverse time order
(newest first)
- Removed private class PageDateComparator and changed code to use
org.apache.wiki.util.PageTimeComparator
Changes to PageTimeComparator
- Added constant DEFAULT_PAGETIME_COMPARATOR to PageTimeComparator
- Implemented PageTimeComparator.equals as requested in a FIXME comment
- Implemented hashCode
Changes to MetaWeblogHandler
- Changed to use new WeblogPlugin.findBlogEntriesSorted method
> Rationalise the use of Collections, particularly with regard to pages
> ---------------------------------------------------------------------
>
> Key: JSPWIKI-528
> URL: https://issues.apache.org/jira/browse/JSPWIKI-528
> Project: JSPWiki
> Issue Type: Improvement
> Reporter: Greg Kable
> Priority: Minor
> Fix For: 3.0
>
> Attachments: jspwiki-528-AttachmentHandler.patch,
> jspwiki-528-LinkCollector.patch, jspwiki-528-SearchProviders.patch,
> jspwiki-528-Weblog.patch, jspwiki-528-workflow.Step.patch
>
>
> Most of the APIs return Collection rather than a finer interface and in many
> cases these collections are repeatedly repacked and resorted unnecessarily. I
> will go through all APIs that return collections of pages and make them
> return a finer interface - probably List for unordered collections and
> SortedSet for ordered collections. This will make the use of these
> collections much clearer for further development and give us some opportunity
> for future optimisations.
> This is likely to be a very wide set of changes across lots of different
> classes so I'll submit separate patches for each class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
