[
https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283877#comment-13283877
]
Jun Rao commented on KAFKA-349:
-------------------------------
That's a good cleanup patch. Thanks. Some comments:
1. Maybe we should use this opportunity to make the error code length in all
responses consistent (use short int instead of int).
2. The response classes don't need to store CurrentVersion since their version
is always the same as the corresponding request.
> Create individual "Response" types for each kind of request and wrap them
> with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests
> except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2,
> kafka_responseSend.patch.3, kafka_responseSend.patch.4
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
