[
https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284590#comment-13284590
]
Jun Rao commented on KAFKA-349:
-------------------------------
Thanks for patch v5. One more comment:
51. FetchResponse,ProducerResponse: We will still need to send the versionId to
the client so that the client knows if it gets the right version of the
response. We just don't need CurrentVersion in FetchResponse/ProducerResponse
since we should just refer to the version constant in
FetchRequest/ProducerRequest.
> Create individual "Response" types for each kind of request and wrap them
> with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests
> except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2,
> kafka_responseSend.patch.3, kafka_responseSend.patch.4,
> kafka_responseSend.patch.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
