On Wed, 01 Sep 2004 07:07:15 -0700, "Vladimir G. Ivanovic" <[EMAIL PROTECTED]> wrote: >Keith, > >Thanks for your quick response! > >1. Should I file a Fedora bug?
Waste of time. RedHat do not want kdb in their trees. >3. I'm now getting a different error: > > gcc -Wp,-MD,kdb/modules/.kdbm_pg.o.d -nostdinc -iwithprefix include -D__KERNEL__ > -Iinclude -Iinclude2 -I/usr/src/linux-2.6.8-1.533/include > -I/usr/src/linux-2.6.8-1.533/kdb/modules -Ikdb/modules -Wall -Wstrict-prototypes > -Wno-trigraphs -fno-strict-aliasing -fno-common -pipe -msoft-float -m32 > -fno-builtin-sprintf -fno-builtin-log2 -fno-builtin-puts > -mpreferred-stack-boundary=2 -march=pentium3 -fno-optimize-sibling-calls > -I/usr/src/linux-2.6.8-1.533/include/asm-i386/mach-default > -Iinclude/asm-i386/mach-default -O2 -g -Wdeclaration-after-statement > -DKBUILD_BASENAME=kdbm_pg -DKBUILD_MODNAME=kdbm_pg -c -o kdb/modules/kdbm_pg.o > /usr/src/linux-2.6.8-1.533/kdb/modules/kdbm_pg.c > /usr/src/linux-2.6.8-1.533/kdb/modules/kdbm_pg.c: In function `kdbm_show_page': > /usr/src/linux-2.6.8-1.533/kdb/modules/kdbm_pg.c:284: error: `PG_maplock' > undeclared (first use in this function) > /usr/src/linux-2.6.8-1.533/kdb/modules/kdbm_pg.c:284: error: (Each undeclared > identifier is reported only once > /usr/src/linux-2.6.8-1.533/kdb/modules/kdbm_pg.c:284: error: for each function it > appears in.) > >The only occurrence of PG_maplock is on line 284 of kdbm_pg.c. Should I >be using a v4.4-2.6.8 patch instead? One of the Fedora patches has deleted PG_maplock from include/linux/page-flags.h. Comparing 2.6.8 with FC3 shows these differences. --- 2.6.8/include/linux/page-flags.h +++ FC3/include/linux/page-flags.h @@ -69,14 +69,11 @@ #define PG_private 12 /* Has something at ->private */ #define PG_writeback 13 /* Page is under writeback */ #define PG_nosave 14 /* Used for system suspend/resume */ -#define PG_maplock 15 /* Lock bit for rmap to ptes */ +#define PG_compound 15 /* Part of a compound page */ #define PG_swapcache 16 /* Swap page: swp_entry_t in private */ #define PG_mappedtodisk 17 /* Has blocks allocated on-disk */ #define PG_reclaim 18 /* To be reclaimed asap */ -#define PG_compound 19 /* Part of a compound page */ - -#define PG_anon 20 /* Anonymous: anon_vma in mapping */ /* @@ -236,6 +233,7 @@ #define PageReserved(page) test_bit(PG_reserved, &(page)->flags) #define SetPageReserved(page) set_bit(PG_reserved, &(page)->flags) #define ClearPageReserved(page) clear_bit(PG_reserved, &(page)->flags) +#define __ClearPageReserved(page) __clear_bit(PG_reserved, &(page)->flags) #define SetPagePrivate(page) set_bit(PG_private, &(page)->flags) #define ClearPagePrivate(page) clear_bit(PG_private, &(page)->flags) @@ -292,10 +290,6 @@ #define SetPageCompound(page) set_bit(PG_compound, &(page)->flags) #define ClearPageCompound(page) clear_bit(PG_compound, &(page)->flags) -#define PageAnon(page) test_bit(PG_anon, &(page)->flags) -#define SetPageAnon(page) set_bit(PG_anon, &(page)->flags) -#define ClearPageAnon(page) clear_bit(PG_anon, &(page)->flags) - #ifdef CONFIG_SWAP #define PageSwapCache(page) test_bit(PG_swapcache, &(page)->flags) #define SetPageSwapCache(page) set_bit(PG_swapcache, &(page)->flags) You will have to adjust the kdb code to compensate. It is a pity that RedHat do not want kdb, it means that RH users have a lot of trouble trying to debug their systems. OTOH SuSE are happy to include kdb in their distributions. --------------------------- Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
