https://bugs.kde.org/show_bug.cgi?id=401637

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kcr
                   |                            |ash/e64b8314e201e255dbb338a
                   |                            |a41317362b545d47a
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit e64b8314e201e255dbb338aa41317362b545d47a by David Edmundson.
Committed on 15/08/2019 at 09:25.
Pushed by davidedmundson into branch 'master'.

Avoid enabling kcrash if it's only included via a plugin

Summary:
If a Qt app happens to load our plasma-integration plugin it shouldn't
change how bug reporting works.

There's no point showing drkonqi if there's not an
appropriate KDE product.

Worse, our crash handling can interfere with that processes own signal
handling.

This patch is effectively a copy of
02b523bad09aab062355e46771889b0f3709692f in kxmlgui for enabling auto-
accelerators only if the lib is linked directly.

Test Plan:
Changed the crashtest app in drkonqi to not directly link - didn't get drkonqi
Re-enabled linking. Got drkonqi

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23171

M  +33   -0    src/kcrash.cpp

https://commits.kde.org/kcrash/e64b8314e201e255dbb338aa41317362b545d47a

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to