https://bugs.kde.org/show_bug.cgi?id=290383
--- Comment #14 from wolthera <griffinval...@gmail.com> --- Git commit 15b1ebf076f476b399161d5928419b7be106c568 by Wolthera van Hövell tot Westerflier. Committed on 24/07/2020 at 09:06. Pushed by woltherav into branch 'wolthera/BUG-290383-colormixopfix'. Fix deform brush by making KoColorMixOp handle non-255 weights. This fixes the bug where this brush slowly outputs everything to transparent. The bug was caused by the fact that to sample the input pixels, the crossdevice color picker was used, which in turn got access to subpixel data by utilizing the randomsubaccessor, which was getting that data by mixing neighbouring pixels via the KoColorMixOp. However, the randomsubaccessor isn't able to generate perfect sums-to-255 weights every single time, meaning transparency was added. This commit fixes that by making the weights in KoColorMixOp always use the sum of the weights as the normalization factor. Special thanks to Dmitry for figuring this out. M +8 -4 libs/pigment/KoMixColorsOpImpl.h https://invent.kde.org/graphics/krita/commit/15b1ebf076f476b399161d5928419b7be106c568 -- You are receiving this mail because: You are watching all bug changes.
