https://bugs.kde.org/show_bug.cgi?id=290383
--- Comment #15 from wolthera <griffinval...@gmail.com> --- Git commit 5101cddfdd340d47503801944c6dfe7906bf088e by Wolthera van Hövell. Committed on 24/07/2020 at 21:54. Pushed by woltherav into branch 'master'. This fixes the bug where this brush slowly outputs everything to transparent. The bug was caused by the fact that to sample the input pixels, the crossdevice color picker was used, which in turn got access to subpixel data by utilizing the randomsubaccessor, which was getting that data by mixing neighbouring pixels via the KoColorMixOp. However, the randomsubaccessor isn't able to generate perfect sums-to-255 weights every single time, meaning transparency was added. This commit fixes that by passing a sum of weights to the KoColorMixOp that only defaults to 255. Special thanks to Dmitry for figuring this out. Note: there's still an issue with colors mixing darker in 8bit, we're still trying to figure that one out. But at the least there's no transparency. M +14 -2 libs/image/kis_random_sub_accessor.cpp M +8 -5 libs/pigment/KoMixColorsOp.h M +8 -7 libs/pigment/KoMixColorsOpImpl.h https://invent.kde.org/graphics/krita/commit/5101cddfdd340d47503801944c6dfe7906bf088e -- You are receiving this mail because: You are watching all bug changes.
