kossebau added a comment.
Some first quick comments, not yet looked at code itself.
Misses also link file from doc/.
INLINE COMMENTS
> ECMGenerateDBusServiceFile.cmake:6
> +# This module provides the ``ecm_generate_dbus_service_file`` function for
> +# generating a D-Bus service file.
> +#
generate and install
> ECMGenerateDBusServiceFile.cmake:22
> +#
> +# Since 5.70.0.
> +
Would be nice to have an example.
Also having each argument discussed in an own section makes getting the docs
easier,
> ECMGenerateDBusServiceFile.cmake:90
> +
> + install(FILES ${_service_file} DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
> +endfunction()
Creates a dependecy on KDEInstallDirs.
ECM/Modules are supposed to be usable in non-KDE-typical setups. So like other
places in this subfolder this macro needs an argument to pass the installation
folder.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D29051
To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy,
michaelh, ngraham, bruns
