kossebau added a comment.
A unit test would be good to have. The test for ECMGeneratePkgConfigFile might be a sample for this. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:17 > +# > +# A D-Bus service file ``<service name>.service` will will be generated and > installed > +# in the relevant D-Bus config location. Computer says: .../extra-cmake-modules/modules/ECMGenerateDBusServiceFile.cmake:17: WARNING: Inline literal start-string without end-string. > ECMGenerateDBusServiceFile.cmake:20 > +# > +# ``<executable>`` must be an absolute path to the service executable. When > using it with > +# ``KDEInstallDirs` it needs to be the ``_FULL_`` variant. I would propopse "to the installed service executable.", to avoid the misunderstanding this is about the copy in the build system. > ECMGenerateDBusServiceFile.cmake:21 > +# ``<executable>`` must be an absolute path to the service executable. When > using it with > +# ``KDEInstallDirs` it needs to be the ``_FULL_`` variant. > +# Same issue: KDEInstallDirs misses double single quotes after it. > ECMGenerateDBusServiceFile.cmake:23 > +# > +# On Windows, only the file name of ``<executable>`` is used since D-Bus > service executables > +# are to be installed in the same directory as the D-Bus daemon. Perhaps phrase it like: "Note: On Windows, the macro will only use the file name part of <executable> since D-Bus service executables are to be installed in the same directory as the D-Bus daemon." Current text still leaves chance to misunderstand that the user in "is used" is the macro caller, not the macro itself :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns
