On Sat, Sep 19, 2015 at 12:07 PM, Boudhayan Gupta <[email protected]> wrote:
> On 19 September 2015 at 21:17, Martin Graesslin <[email protected]> > wrote: > > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote: > >> If the problem is somewhere in (a), where is it? > > > > I'm afraid of code review happening through the pull request instead of > our > > infrastructure. To me github pull requests are not just the "here's the > > patch", but also the code review. > > This. > > The other problem is that the PR submitter may not have a KDE > identity, in which case we have no way of representing the fellow and > properly crediting the commit to him/her. We have to explicitly > redirect him to KDE's infrastructure for this. > That is not true. You can credit any commit to anyone git commit --author "My Name <[email protected]>" which is a standard practice around KDE, when committing patches on behalf of newcomers who don't have write access. Cheers -- Martin Klapetek | KDE Developer
_______________________________________________ kde-community mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-community
