----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101885/#review4590 -----------------------------------------------------------
aside from the blocking nature of the call which is easily fixable, i'm not in favour of adding specific calls to a specific DBus service that may or may not change implementation at any given point in the future. there's a reason why there is library for this: to hide such things behind a function driven API rather than gluing together DBus calls. the entire _point_ of having libraries in experimental/ is so that they can be _used_ by code in, e.g., kdelibs or workspace without committing immediately to API stability. if that isn't possible, then we may as well cease kdelibs/experimental/ as it then provides zero benefit. aside from that, it would make a lot of sense imho to take this opportunity to re-think the mechanism behind KRecentDocument: do we want to continue having a flat file on disk as well as a ranked version of the same data as processed by a desktop events system? kio/kfile/krecentdocument.cpp <http://git.reviewboard.kde.org/r/101885/#comment4012> should be an asyncCall? - Aaron J. On July 8, 2011, 5:28 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101885/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 5:28 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > KRecentDocument now sends info about opened files to the K Activity Manager > Daemon so that it can calculate scores for the opened files. > > DBus call is made directly instead of using the libkactivities since the > library is still in kdelibs/experimental, and the call is quite simple. > > > Diffs > ----- > > kio/kfile/krecentdocument.cpp a7f92839e86775e6a2a88073126f1baf6f213e92 > > Diff: http://git.reviewboard.kde.org/r/101885/diff > > > Testing > ------- > > Been testing for a couple of months now > > > Thanks, > > Ivan > >
