> On July 11, 2011, 11:24 a.m., Aaron J. Seigo wrote: > > kio/kfile/krecentdocument.cpp, line 103 > > <http://git.reviewboard.kde.org/r/101885/diff/1/?file=26347#file26347line103> > > > > should be an asyncCall?
yes, we don't need a return value or anything apart from that, can I commit? - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101885/#review4590 ----------------------------------------------------------- On July 8, 2011, 5:28 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101885/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 5:28 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > KRecentDocument now sends info about opened files to the K Activity Manager > Daemon so that it can calculate scores for the opened files. > > DBus call is made directly instead of using the libkactivities since the > library is still in kdelibs/experimental, and the call is quite simple. > > > Diffs > ----- > > kio/kfile/krecentdocument.cpp a7f92839e86775e6a2a88073126f1baf6f213e92 > > Diff: http://git.reviewboard.kde.org/r/101885/diff > > > Testing > ------- > > Been testing for a couple of months now > > > Thanks, > > Ivan > >