> On July 11, 2011, 11:24 a.m., Aaron J. Seigo wrote: > > kio/kfile/krecentdocument.cpp, line 103 > > <http://git.reviewboard.kde.org/r/101885/diff/1/?file=26347#file26347line103> > > > > should be an asyncCall? > > Ivan Čukić wrote: > yes, we don't need a return value or anything > > apart from that, can I commit? > > Aaron J. Seigo wrote: > personally, i don't see why libkactivities can not be used here. it > literally makes zero sense to have a library in experimental and then not use > it because it is experimental. iow, either we get rid of the library and just > sprinkle dbus calls and duplicated code everywhere (which would be insane) or > we use the library as an internal dependency. how else are we supposed to > ensure libkactivities matures? or is the plan to just let it sit there in > kdelibs/experimental and never actually be used? > > so, no, i'm not personally in favor of seeing this patch go in as-is. i > think it should be using libkactivities. > > Ivan Čukić wrote: > The reason is quite simple - kdelibs can not depend on > kdelibs/experimental > > If you recall, that was one of the stoppers for 4.7 because libplasma > depended on experimental libkdeclarative (or whatever the name was) and > copying the whole libkactivities in private section (like it was the case for > the aforementioned) of kio libraries for one single call to the service is a > bit too much. > > When libkactivities goes out of experimental, we can change this > (although, again, making deps between libs for one extremely simple call is > something that can be discussed further) > > Aaron J. Seigo wrote: > > The reason is quite simple - kdelibs can not depend on > kdelibs/experimental > > yes, and that is my point of contention. the reason for > kdelibs/experimental is to use the libraries as internal, non-public > dependencies to allow them to be tested in real world scenarios before > entering 'real world' usage as full fledged members of kdelibs. whoever it > was that decided that kdelibs/experimental should be packaged separately and > treated as "can't be used as a dependency" made a mistake. > > unfortunately i was too busy with other things to notice and correct this > mistake in time for 4.7. doesn't mean we have to keep perpetuating it, > however.
Oh, so you'd like to have them link to one another? Ok, can do :) - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101885/#review4590 ----------------------------------------------------------- On July 8, 2011, 5:28 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101885/ > ----------------------------------------------------------- > > (Updated July 8, 2011, 5:28 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > KRecentDocument now sends info about opened files to the K Activity Manager > Daemon so that it can calculate scores for the opened files. > > DBus call is made directly instead of using the libkactivities since the > library is still in kdelibs/experimental, and the call is quite simple. > > > Diffs > ----- > > kio/kfile/krecentdocument.cpp a7f92839e86775e6a2a88073126f1baf6f213e92 > > Diff: http://git.reviewboard.kde.org/r/101885/diff > > > Testing > ------- > > Been testing for a couple of months now > > > Thanks, > > Ivan > >
