----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review14874 -----------------------------------------------------------
Good idea, but it seems to break the case where nested dirs exist in the directory being restored. Everything gets flattened out. Probably a bug in CopyJob though, in the handling of fileNameUsedForCopying=DisplayName - David Faure On June 18, 2012, 5:39 p.m., Michael Reeves wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105078/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 5:39 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This patch makes drag-and-drop and cut/paste from trash preserve the orginal > filename instead of appending "0-". > > > This addresses bug 183403. > http://bugs.kde.org/show_bug.cgi?id=183403 > > > Diffs > ----- > > kioslave/trash/kio_trash.cpp 4187f45 > kioslave/trash/trash.protocol f96d4a1 > > Diff: http://git.reviewboard.kde.org/r/105078/diff/ > > > Testing > ------- > > I have used the modified io_trash module on my machine since before the KDE > 4.8 release and still use it under KDE 4.8.3. > > > Thanks, > > Michael Reeves > >
