> On Oct. 7, 2012, 3:32 p.m., Jacopo De Simoi wrote: > > I do not want the notifier to show this information in the device view; > > indeed, for devices with a label, the mount point is /media/<label>, so the > > information about the mount point would look like quite redundant. > > Perhaps you could show it in a tooltip, instead; that would be acceptable > > imho > > > > In any case, the “trouble with unmounting” usecase should be resolved in > > some other way (e.g. by making use of lsof in solid to identify blocking > > apps), so I am not super-sure that the user should be given such specific > > information as /dev/xxxx. > >
agreed. this is debugging info and as such would be visual noise 99%+ of the time. worse yet, this is jargon, the kind of thing we don't want to shove in the average user's face. as an alternative, this information could go into a Properties dialog that is accessible from the Devices section of Places (e.g. what Dolphin uses in its sidebar) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/#review20039 ----------------------------------------------------------- On Oct. 7, 2012, 2:55 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106755/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2012, 2:55 p.m.) > > > Review request for KDE Base Apps and Plasma. > > > Description > ------- > > If a removable device is mounted using the Plasma device notifier, there is > no indication of what the Unix name of the device is or where it is mounted. > This information may be useful to the user for (a) accessing the mounted > device from non-KDE applications, or (b) troubleshooting mounting or > unmounting problems. > > The attached patch shows this information when the device is hovered over, > just above the "N actions for this device" text. Depending on whether or not > the device is mounted, there are three possibilities that can be shown here: > > /dev/XXX when not mounted > /dev/XXX mounted on /media/YYYY when mounted > /dev/XXX mounted if mounted but the mount point is not > available > > Please be gentle, this is my first QML patch :-) > > > This addresses bug 196939. > http://bugs.kde.org/show_bug.cgi?id=196939 > > > Diffs > ----- > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml > 2a9b3f7 > > Diff: http://git.reviewboard.kde.org/r/106755/diff/ > > > Testing > ------- > > Built kde-workspace with this change, observed operation and display of > device notifier with a selection of removable devices. > > > Screenshots > ----------- > > Device notifier with mounted device > http://git.reviewboard.kde.org/r/106755/s/756/ > > > Thanks, > > Jonathan Marten > >
