----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/#review20057 -----------------------------------------------------------
any application which expects the user to access files on disk but does not provide a clear representation of mounted / removable devices is broken. there's no point in degrading our own primary UI for such fixable brokenness. can you provide a (short :) list of any such broken applications which are high-profile / in common use? - Aaron J. Seigo On Oct. 8, 2012, 9:31 a.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106755/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 9:31 a.m.) > > > Review request for KDE Base Apps and Plasma. > > > Description > ------- > > If a removable device is mounted using the Plasma device notifier, there is > no indication of what the Unix name of the device is or where it is mounted. > This information may be useful to the user for (a) accessing the mounted > device from non-KDE applications, or (b) troubleshooting mounting or > unmounting problems. > > The attached patch shows this information when the device is hovered over, > just above the "N actions for this device" text. Depending on whether or not > the device is mounted, there are three possibilities that can be shown here: > > /dev/XXX when not mounted > /dev/XXX mounted on /media/YYYY when mounted > /dev/XXX mounted if mounted but the mount point is not > available > > Please be gentle, this is my first QML patch :-) > > > This addresses bug 196939. > http://bugs.kde.org/show_bug.cgi?id=196939 > > > Diffs > ----- > > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml > 396de2c > > Diff: http://git.reviewboard.kde.org/r/106755/diff/ > > > Testing > ------- > > Built kde-workspace with this change, observed operation and display of > device notifier with a selection of removable devices. > > > Screenshots > ----------- > > Device notifier with mounted device > http://git.reviewboard.kde.org/r/106755/s/756/ > > > Thanks, > > Jonathan Marten > >
