On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer <[email protected]> wrote:

>
> I think you can remove m_accessToken, m_path and m_queryItems from
> FacebookJob.
> Access token and path are already set on m_url and addQueryItem can be
> implemented to just call m_url.addQueryItem().
>
> Also, virtual void start() = 0 is already part of KJob's API, so not needed
> again.
>

Good points, all fixed.

Cheers
-- 
Martin Klapetek | KDE Developer

Reply via email to