On Monday, 2012-10-29, Martin Klapetek wrote: > On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer <[email protected]> wrote: > > I think you can remove m_accessToken, m_path and m_queryItems from > > FacebookJob. > > Access token and path are already set on m_url and addQueryItem can be > > implemented to just call m_url.addQueryItem(). > > > > Also, virtual void start() = 0 is already part of KJob's API, so not > > needed again. > > Good points, all fixed.
Almost :) FacebookJob::m_queryItems is still there. can probably also remove the typedef for QueryItem. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring
signature.asc
Description: This is a digitally signed message part.
