El Dissabte, 27 d'octubre de 2012, a les 11:00:42, Martin Klapetek va escriure: > Hi, > > I'd like to move libkfacebook, the foundation for akonadi-facebook > resource, into extragear. It's been in use for a while, lots of distro ship > it bundled with akonadi-facebook resource, which is now becaming part of > kdepim-runtime for 4.10 with libkfacebook as optional compile-time > dependency. > > I'd like to ask for a review of this library, currently in kdereview - > https://projects.kde.org/projects/kdereview/libkfacebook
You don't seem to be using d-pointers, can you please fix that? My moc complains about postinfo.h:46: Warning: Property declaration from has no READ accessor function. The property will be invalid. postinfo.h:54: Warning: Property declaration properties has no READ accessor function. The property will be invalid. postinfo.h:60: Warning: Property declaration application has no READ accessor function. The property will be invalid. notificationinfo.h:46: Warning: Property declaration from has no READ accessor function. The property will be invalid. notificationinfo.h:47: Warning: Property declaration to has no READ accessor function. The property will be invalid. notificationinfo.h:52: Warning: Property declaration application has no READ accessor function. The property will be invalid. Cheers, Albert > > Thanks
