El Dimecres, 7 de novembre de 2012, a les 20:20:56, Martin Klapetek va escriure: > On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid <[email protected]> wrote: > > El Dilluns, 5 de novembre de 2012, a les 22:59:43, Martin Klapetek va > > > > escriure: > > > On Mon, Nov 5, 2012 at 7:52 PM, Pino Toscano <[email protected]> wrote: > > > > Some notes: > > > > > > > > - as others have pointed out, public classes should be better use > > > > d-pointers; for the jobs hierarchy, you could use a shared d-pointer, > > > > see [1] for example > > > > > > The data classes are finally done - all of them now use d-pointers and > > > > none > > > > > are qobject; I've added the qobject-parsers as Kevin suggested, please > > > > give > > > > > it a look. > > > > You sure? I still see a lots of d-pointers missing (AllEventsListJob, > > AllNotesListJob, etc). > > Yes, I meant the data classes, those are the *Info classes. I'll see the > rest over the weekend hopefully.
Ah, sorry > > > Also you have some classes without the export thingie, like AttendeeInfo > > or > > the facebookTimeToKDateTime function > > They are not to be exported, only for internal purposes. Why are they in installed headers then? Cheers, Albert > > Cheers
