----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23532 -----------------------------------------------------------
cmake/modules/KDE4Macros.cmake <http://git.reviewboard.kde.org/r/107752/#comment18079> Wouldn't it be nicer to write a loop for this with the icon resolutions? - Laszlo Papp On Dec. 16, 2012, 7:26 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107752/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 7:26 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > There are two issues when using kde4_add_app_icon on mac. a) apps using > kdeinit won't install icon files to thier app bundles, b) mac app icon > generating method is outdated and does not support retina resolution. > > The patch changed kde4_add_kdeinit_executable and kde4_add_app_icon to solve > these issues. > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 0753879 > > Diff: http://git.reviewboard.kde.org/r/107752/diff/ > > > Testing > ------- > > Works well on 4.9 branch. > Not sure if some changes breaks other platforms. > > > Thanks, > > Yue Liu > >
