> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > <http://git.reviewboard.kde.org/r/107752/diff/1/?file=99544#file99544line1293> > > > > Wouldn't it be nicer to write a loop for this with the icon resolutions? > > Yue Liu wrote: > osx icon only uses some specific resolution, 22x22 and 48x48 are not used. > > Yue Liu wrote: > and for some resolutions one icon is needed, for some two icons are > needed (like 16x16@2x and 32x32, both are 32x32)
Yes, so? You have 2-3 factors, but most of the code is the same for all. In other words, that is what functions exist for with parameters. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23532 ----------------------------------------------------------- On Dec. 16, 2012, 7:26 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107752/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 7:26 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > There are two issues when using kde4_add_app_icon on mac. a) apps using > kdeinit won't install icon files to thier app bundles, b) mac app icon > generating method is outdated and does not support retina resolution. > > The patch changed kde4_add_kdeinit_executable and kde4_add_app_icon to solve > these issues. > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 0753879 > > Diff: http://git.reviewboard.kde.org/r/107752/diff/ > > > Testing > ------- > > Works well on 4.9 branch. > Not sure if some changes breaks other platforms. > > > Thanks, > > Yue Liu > >