----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/ -----------------------------------------------------------
(Updated Dec. 20, 2012, 6:10 p.m.) Review request for kdelibs. Changes ------- changed repeated codes with a macro Description ------- There are two issues when using kde4_add_app_icon on mac. a) apps using kdeinit won't install icon files to thier app bundles, b) mac app icon generating method is outdated and does not support retina resolution. The patch changed kde4_add_kdeinit_executable and kde4_add_app_icon to solve these issues. Diffs (updated) ----- cmake/modules/KDE4Macros.cmake 0753879 Diff: http://git.reviewboard.kde.org/r/107752/diff/ Testing ------- Works well on 4.9 branch. Not sure if some changes breaks other platforms. Thanks, Yue Liu
