----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/#review33368 -----------------------------------------------------------
kdeui/dialogs/kpassworddialog.cpp <http://git.reviewboard.kde.org/r/110643/#comment24681> comboboxes are editable by default, so this line can be removed kdeui/tests/kpassworddialogtest.cpp <http://git.reviewboard.kde.org/r/110643/#comment24682> QObject::tr() is a big no no, say the Qt devs. The context has to be either implicit (tr() inside a QObject subclass), or explicit (QCoreApplication::translate("...", ...)). But this is a test program, so it's completely pointless to translate, except "to show how to do things right". But then that means i18n(), for people writing KDE apps by looking at this code. So unless this creates a problematic dependency, I'd say just keep i18n() for now. - David Faure On May 25, 2013, 12:57 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110643/ > ----------------------------------------------------------- > > (Updated May 25, 2013, 12:57 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Known "bugs" > - there's no clear icon in the text field anymore as I had to port away from > KLineEdit > > Diff shown is without the actual moving for easier reviewing. > > > Diffs > ----- > > kdeui/CMakeLists.txt cfa29ef > kdeui/dialogs/kpassworddialog.h e554c2a > kdeui/dialogs/kpassworddialog.cpp 168271c > kdeui/dialogs/kpassworddialog.ui 95845b9 > kdeui/tests/CMakeLists.txt cd055d5 > kdeui/tests/kpassworddialogtest.cpp b1c55ee > tier1/kwidgetsaddons/src/CMakeLists.txt df22699 > tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 > > Diff: http://git.reviewboard.kde.org/r/110643/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
