> On June 3, 2013, 10:15 a.m., David Faure wrote:
> > Ship It!
>
> David Edmundson wrote:
> Is the lineedit clear button a problem?
No, there is work going on in Qt so that QLineEdit will provide this.
You should add a
#pragma message("KF5 TODO: enable clear button in QLineEdit once available")
though, to reduce the risks of forgetting.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110643/#review33631
-----------------------------------------------------------
On June 2, 2013, 1:24 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110643/
> -----------------------------------------------------------
>
> (Updated June 2, 2013, 1:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Known "bugs"
> - there's no clear icon in the text field anymore as I had to port away from
> KLineEdit
>
> Diff shown is without the actual moving for easier reviewing.
>
>
> Diffs
> -----
>
> tier1/kwidgetsaddons/src/kpassworddialog.h e554c2a
> tier1/kwidgetsaddons/src/CMakeLists.txt df22699
> kdeui/CMakeLists.txt 46e08df
> kdeui/tests/CMakeLists.txt 5c1f386
> tier1/kwidgetsaddons/src/kpassworddialog.cpp 168271c
> tier1/kwidgetsaddons/src/kpassworddialog.ui 95845b9
> tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4
> tier1/kwidgetsaddons/tests/kpassworddialogtest.cpp b1c55ee
>
> Diff: http://git.reviewboard.kde.org/r/110643/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Kde-frameworks-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
