> On May 29, 2013, 4:22 p.m., David Faure wrote: > > kdeui/dialogs/kpassworddialog.cpp, line 347 > > <http://git.reviewboard.kde.org/r/110643/diff/1/?file=146196#file146196line347> > > > > comboboxes are editable by default, so this line can be removed > > David Edmundson wrote: > Qt docs say it is not editable by default. > > http://doc-snapshot.qt-project.org/qt5-stable/qtwidgets/qcombobox.html#editable-prop > >
Oops, OK. Remembered wrong. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/#review33368 ----------------------------------------------------------- On June 2, 2013, 1:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110643/ > ----------------------------------------------------------- > > (Updated June 2, 2013, 1:24 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Known "bugs" > - there's no clear icon in the text field anymore as I had to port away from > KLineEdit > > Diff shown is without the actual moving for easier reviewing. > > > Diffs > ----- > > tier1/kwidgetsaddons/src/kpassworddialog.h e554c2a > tier1/kwidgetsaddons/src/CMakeLists.txt df22699 > kdeui/CMakeLists.txt 46e08df > kdeui/tests/CMakeLists.txt 5c1f386 > tier1/kwidgetsaddons/src/kpassworddialog.cpp 168271c > tier1/kwidgetsaddons/src/kpassworddialog.ui 95845b9 > tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 > tier1/kwidgetsaddons/tests/kpassworddialogtest.cpp b1c55ee > > Diff: http://git.reviewboard.kde.org/r/110643/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
