----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review48754 -----------------------------------------------------------
Build checked with 2.8.12.0, but see below. autotests/CMakeLists.txt <https://git.reviewboard.kde.org/r/115424/#comment34414> What happens if Qt5Test is not found? Presumably, this should either be REQUIRED or the tests should be wrapped in an if() tests/CMakeLists.txt <https://git.reviewboard.kde.org/r/115424/#comment34415> Same here - Alex Merry On Feb. 1, 2014, 6:28 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115424/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2014, 6:28 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > - QtNetwork is not used > - QtTest is only required for tests > - Remove transitive dependencies > > > Diffs > ----- > > tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810 > autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9 > CMakeLists.txt fe6de305d28c2cd073ae1bc5d171f1244d2ed29c > > Diff: https://git.reviewboard.kde.org/r/115424/diff/ > > > Testing > ------- > > Inspection of source. Builds. Tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
