----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review49264 -----------------------------------------------------------
Ship it! Looks good, but then you have 56 other frameworks where to add a if(BUILD_TESTING) around add_subdirectory(tests) and add_subdirectory(autotests) :-) - David Faure On Feb. 8, 2014, 5:32 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115424/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2014, 5:32 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > - QtNetwork is not used > - QtTest is only required for tests > - Remove transitive dependencies > > > Diffs > ----- > > CMakeLists.txt 8d7a76250a3977120f014eb735a2ef66ca5d59ea > autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9 > tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810 > > Diff: https://git.reviewboard.kde.org/r/115424/diff/ > > > Testing > ------- > > Inspection of source. Builds. Tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
