> On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
> > Looks good, but then you have 56 other frameworks where to add a
> > if(BUILD_TESTING) around add_subdirectory(tests) and
> > add_subdirectory(autotests) :-)
>
> Michael Palimaka wrote:
> That's fine, do I need to do a review request for all of those that have
> just that change?
>
> David Faure wrote:
> No, if that's the only change, it doesn't need to be reviewed, go ahead.
> Review your own diff though :-)
>
>
> Michael Palimaka wrote:
> Actually, it looks like a lot of frameworks already do something like
> this in autotests/CMakeLists.txt:
>
> find_package(Qt5Test ${REQUIRED_QT_VERSION} CONFIG QUIET)
>
> if(NOT Qt5Test_FOUND)
> message(STATUS "Qt5Test not found, autotests will not be built.")
> return()
> endif()
>
> Should we punt this in favour of BUILD_TESTING check?
I would say so (it's more common to not want to build tests, to save time, than
to be missing Qt5Test in the first place).
So explicit control with -DBUILD_TESTING seems better.
But please check with Alex Richardson who committed such code, to be sure
everyone's ok with this.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review49264
-----------------------------------------------------------
On Feb. 8, 2014, 5:39 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115424/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2014, 5:39 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kparts
>
>
> Description
> -------
>
> - QtNetwork is not used
> - QtTest is only required for tests
> - Remove transitive dependencies
>
>
> Diffs
> -----
>
> CMakeLists.txt 8d7a76250a3977120f014eb735a2ef66ca5d59ea
> autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9
> tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810
>
> Diff: https://git.reviewboard.kde.org/r/115424/diff/
>
>
> Testing
> -------
>
> Inspection of source. Builds. Tests pass.
>
>
> Thanks,
>
> Michael Palimaka
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
