dfaure added inline comments.


> marcingu wrote in thumbnail.cpp:776
> How about I set it to -1 at start and check for that instead? I checked 
> definitions and it looks like dev_st is unsigned, but it shouldn't be a 
> problem.

-1 isn't exactly a great value for an unsigned int :-)

Or rather, it's not great enough (in the "greater than" sense) :-)

But yeah, 0xFFFFFFFF is a good "not set yet" value for a dev_t, to be safe 
against the possibility of 0.

  R320 KIO Extras


To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

Reply via email to