----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/#review64264 -----------------------------------------------------------
src/kstandardaction.cpp <https://git.reviewboard.kde.org/r/119713/#comment44914> Wouldn't it be better to use something like this? QIcon::setThemeSearchPaths(QIcon::themeSearchPaths()+thePathFor("breeze")); - Aleix Pol Gonzalez On Aug. 11, 2014, 1:24 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119713/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 1:24 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > ------- > > I am running KGeography in a user which has oxygen icons available but since > i'm not running neither the kde QPT nor oxygen style nor anything, while > moving from KIcon to QIcon::fromTheme i lost most of my icons (since there is > no kiconloader in the middle anymore), and the same for kstandardaction icons. > > This patch makes it so that if you are using kstandardactions and your icon > theme is hicolor but you have breeze or oxygen installed it changes the theme > to one of those. > > I am unconvinced if we want this here or if i want this in my (and > potentially) every application so when we run in Gnome or Unity, our apps get > icons what were getting in kde4 times because they were using KIcon and they > would lose now because of the QIcon::fromTheme recommendation. > > > Diffs > ----- > > src/kstandardaction.cpp a18527b > > Diff: https://git.reviewboard.kde.org/r/119713/diff/ > > > Testing > ------- > > KGeography menu items have icons again. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
