> On ago. 11, 2014, 1:54 p.m., Aleix Pol Gonzalez wrote:
> > src/kstandardaction.cpp, line 48
> > <https://git.reviewboard.kde.org/r/119713/diff/1/?file=303736#file303736line48>
> >
> > Wouldn't it be better to use something like this?
> >
> >
> > QIcon::setThemeSearchPaths(QIcon::themeSearchPaths()+thePathFor("breeze"));
Icon::themeSearchPaths() contains ("/home/kdeunstable/instalado/share/icons",
"/usr/share/icons", ":/icons") which actually already contains the breeze and
oxygen folders, it's just that unconfigured Qt5 defauls to hicolor which means
you get no icon at all.
I also undestand that forcing icons this way it's weird, not really convinced
this is the way to go.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119713/#review64264
-----------------------------------------------------------
On ago. 11, 2014, 1:24 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119713/
> -----------------------------------------------------------
>
> (Updated ago. 11, 2014, 1:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> I am running KGeography in a user which has oxygen icons available but since
> i'm not running neither the kde QPT nor oxygen style nor anything, while
> moving from KIcon to QIcon::fromTheme i lost most of my icons (since there is
> no kiconloader in the middle anymore), and the same for kstandardaction icons.
>
> This patch makes it so that if you are using kstandardactions and your icon
> theme is hicolor but you have breeze or oxygen installed it changes the theme
> to one of those.
>
> I am unconvinced if we want this here or if i want this in my (and
> potentially) every application so when we run in Gnome or Unity, our apps get
> icons what were getting in kde4 times because they were using KIcon and they
> would lose now because of the QIcon::fromTheme recommendation.
>
>
> Diffs
> -----
>
> src/kstandardaction.cpp a18527b
>
> Diff: https://git.reviewboard.kde.org/r/119713/diff/
>
>
> Testing
> -------
>
> KGeography menu items have icons again.
>
>
> Thanks,
>
> Albert Astals Cid
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
