> On April 24, 2015, 2:47 p.m., Matthew Dawson wrote: > > autotests/kconfig_compiler/test13.cpp.ref, line 33 > > <https://git.reviewboard.kde.org/r/123367/diff/7-8/?file=362762#file362762line33> > > > > Is there a reason this got moved back? > > Aleix Pol Gonzalez wrote: > Well, Modified needs to be called together with Changed, because it's > called when it changes. Right? > > I left it there because it seemed to me it was fine there, am I wrong? In > fact, I was thinking about just connecting Changed to modified, but I guessed > this was more explicit.
I suggested the extra signal, that way when the KConfigSkeleton loads new values from the underlying KConfig the QML code would get notified. But if the check is in usrWriteConfig, then that value change won't be picked up until the save function is called. It seems brightnessChanged type signals are used for a different purpose (notifying about changes on save), so just using that won't work. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79473 ----------------------------------------------------------- On April 24, 2015, 12:56 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123367/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 12:56 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > The generation of those classes makes it useful to have these being used > within C++ application. This change makes it possible to use these classes > from QML as well. > > For each variable, exposes the getter. In case there's a setter, it will add > a notify signal and the setter to the property. > > > Diffs > ----- > > autotests/kconfig_compiler/CMakeLists.txt 0cca605 > autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce > autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION > autotests/kconfig_compiler/test13.h.ref PRE-CREATION > autotests/kconfig_compiler/test13.kcfg PRE-CREATION > autotests/kconfig_compiler/test13.kcfgc PRE-CREATION > autotests/kconfig_compiler/test13main.cpp PRE-CREATION > autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef > autotests/kconfig_compiler/test_signal.h.ref 19b8b40 > src/kconfig_compiler/kconfig_compiler.cpp 5aae340 > > Diff: https://git.reviewboard.kde.org/r/123367/diff/ > > > Testing > ------- > > KConfig tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
