----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87694 -----------------------------------------------------------
Reopened because now everyone has the crash I was complaining on the reviews there: https://git.reviewboard.kde.org/r/125613/ Will have to look into how to fix properly, whatever that means. - Aleix Pol Gonzalez On Oct. 29, 2015, 1:35 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125164/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 1:35 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Scheduler::jobFinished cleans up the job but doesn't report it as such. > > > Diffs > ----- > > src/core/simplejob.cpp 3380cbe > autotests/jobtest.cpp c24bcea > autotests/jobtest.h ef8c3e1 > > Diff: https://git.reviewboard.kde.org/r/125164/diff/ > > > Testing > ------- > > Added a test and made it pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel