-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 12:46 p.m.)


Review request for KDE Frameworks.


Changes
-------

Updated the patch not to try to kill jobs that already finished, as suggested 
by David.

Still doesn't solve the issue.

```
snapshot(2084)/(default) unknown: No file found for ".xml" , even though 
update-mime-info said it would exist.
ksnapshot(2084)/(default) unknown: Either it was just removed, or the directory 
doesn't have executable permission...
ksnapshot(2084)/(default) unknown: ("/home/apol/.local/share/mime", 
"/home/kde-devel/kde5/share/mime", "/usr/share/mime")
ksnapshot(2084)/(default) KIO::SimpleJob::doKill: killing a job that already 
finished KIO::ListJob(0xec3f90)
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.png")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.bmp")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.bmp")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.png")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Items emitted in 
directory QUrl("file:///home/apol/Documents") but that directory isn't in 
KDirModel! Root directory: QUrl("file:///home/apol/imatges")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Item: 
QUrl("file:///home/apol/Documents/sudokuTitle.png")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Item: 
QUrl("file:///home/apol/Documents/firma.png")                                   
                                                                                
                                               
ksnapshot(2084)/(default) KDirModelPrivate::dump: Dumping contents of KDirModel 
KDirModel(0xa3c5f0) dirLister url: QUrl("file:///home/apol/imatges")            
                                                                                
                                  
ksnapshot(2084)/(default) unknown: ASSERT: "result" in file 
/home/kde-devel/frameworks/kio/src/widgets/kdirmodel.cpp, line 433              
                                                                                
                                                      
                                                                                
                                                                                
                                                                                
                                  
Program received signal SIGABRT, Aborted.                                       
                                                                                
                                                                                
                                  
0x00007ffff22885f8 in raise () from /usr/lib/libc.so.6                          
                                                                                
                                                                                
                                  
(gdb) where                                                                     
                                                                                
                                                                                
                                  
#0  0x00007ffff22885f8 in raise () from /usr/lib/libc.so.6                      
                                                                                
                                                                                
                                  
#1  0x00007ffff2289a7a in abort () from /usr/lib/libc.so.6                      
                                                                                
                                                                                
                                  
#2  0x00007ffff2f2805e in qt_message_fatal (context=..., message=<synthetic 
pointer>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1610      
                                                                                
                         
#3  QMessageLogger::fatal (this=this@entry=0x7fffffff9960, 
msg=msg@entry=0x7ffff31db7f0 "ASSERT: \"%s\" in file %s, line %d") at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:784       
                                                                 
#4  0x00007ffff2f235de in qt_assert (assertion=<optimized out>, file=<optimized 
out>, line=<optimized out>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3046       
                                                                                
   
Python Exception <class 'gdb.error'> cannot resolve overloaded method `data': 
no arguments supplied:                                                          
                                                                                
                                    
#5  0x00007ffff7b72567 in KDirModelPrivate::_k_slotNewItems (this=0xa3c190, 
directoryUrl=, items=...) at 
/home/kde-devel/frameworks/kio/src/widgets/kdirmodel.cpp:433                    
                                                                                
         
#6  0x00007ffff7b7618a in KDirModel::qt_static_metacall (_o=0xa3c5f0, 
_c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7fffffff9d50) at 
src/widgets/moc_kdirmodel.cpp:107                                               
                                                             
#7  0x00007ffff3140e6a in QMetaObject::activate (sender=0xa3b380, 
signalOffset=<optimized out>, local_signal_index=<optimized out>, 
argv=<optimized out>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3730       
                                     
Python Exception <class 'gdb.error'> cannot resolve overloaded method `data': 
no arguments supplied:                                                          
                                                                                
                                    
#8  0x00007ffff64039f7 in KCoreDirLister::itemsAdded (this=0xa3b380, _t1=, 
_t2=...) at src/core/moc_kcoredirlister.cpp:522                                 
                                                                                
                                       
#9  0x00007ffff64017f0 in KCoreDirLister::Private::emitItems (this=0xa3bee0) at 
/home/kde-devel/frameworks/kio/src/core/kcoredirlister.cpp:2566                 
                                                                                
                                  
#10 0x00007ffff63f9c58 in KCoreDirListerCache::slotEntries (this=0x7ffff669b920 
<(anonymous namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, 
job=0xec3f90, entries=QList<KIO::UDSEntry> = {...}) at 
/home/kde-devel/frameworks/kio/src/core/kcoredirlister.cpp:1274
#11 0x00007ffff6403dad in KCoreDirListerCache::qt_static_metacall 
(_o=0x7ffff669b920 <(anonymous 
namespace)::Q_QGS_kDirListerCache::innerFunction()::holder>, 
_c=QMetaObject::InvokeMetaMethod, _id=7, _a=0x7fffffffa280) at 
src/core/moc_kcoredirlister_p.cpp:132
#12 0x00007ffff3140e6a in QMetaObject::activate (sender=0xec3f90, 
signalOffset=<optimized out>, local_signal_index=<optimized out>, 
argv=<optimized out>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3730
#13 0x00007ffff63b29bf in KIO::ListJob::entries (this=0xec3f90, _t1=0xec3f90, 
_t2=QList<KIO::UDSEntry> = {...}) at src/core/moc_listjob.cpp:261
#14 0x00007ffff63b17b6 in KIO::ListJobPrivate::slotListEntries (this=0xea7330, 
list=QList<KIO::UDSEntry> = {...}) at 
/home/kde-devel/frameworks/kio/src/core/listjob.cpp:151
#15 0x00007ffff63b24dd in KIO::ListJob::qt_static_metacall (_o=0xec3f90, 
_c=QMetaObject::InvokeMetaMethod, _id=7, _a=0x7fffffffa6e0) at 
src/core/moc_listjob.cpp:130
#16 0x00007ffff3140e6a in QMetaObject::activate (sender=0x8b7400, 
signalOffset=<optimized out>, local_signal_index=<optimized out>, 
argv=<optimized out>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3730
#17 0x00007ffff639f373 in KIO::SlaveInterface::listEntries (this=0x8b7400, 
_t1=QList<KIO::UDSEntry> = {...}) at src/core/moc_slaveinterface.cpp:416
Python Exception <class 'gdb.error'> cannot resolve overloaded method `data': 
no arguments supplied: 
#18 0x00007ffff639d3c2 in KIO::SlaveInterface::dispatch (this=0x8b7400, 
_cmd=106, rawdata=) at 
/home/kde-devel/frameworks/kio/src/core/slaveinterface.cpp:177
#19 0x00007ffff639cfa0 in KIO::SlaveInterface::dispatch (this=0x8b7400) at 
/home/kde-devel/frameworks/kio/src/core/slaveinterface.cpp:89
#20 0x00007ffff63a10a0 in KIO::Slave::gotInput (this=0x8b7400) at 
/home/kde-devel/frameworks/kio/src/core/slave.cpp:393
#21 0x00007ffff6426c7d in KIO::Slave::qt_static_metacall (_o=0x8b7400, 
_c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7fffffffaad0) at 
src/core/moc_slave.cpp:87
#22 0x00007ffff3140e6a in QMetaObject::activate (sender=0xb93530, 
signalOffset=<optimized out>, local_signal_index=<optimized out>, 
argv=<optimized out>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3730
#23 0x00007ffff634dff7 in KIO::Connection::readyRead (this=0xb93530) at 
src/core/moc_connection_p.cpp:141
#24 0x00007ffff634ce2b in KIO::ConnectionPrivate::dequeue (this=0xa74720) at 
/home/kde-devel/frameworks/kio/src/core/connection.cpp:45
#25 0x00007ffff634de22 in KIO::Connection::qt_static_metacall (_o=0xb93530, 
_c=QMetaObject::InvokeMetaMethod, _id=1, _a=0xa783c0) at 
src/core/moc_connection_p.cpp:85
#26 0x00007ffff3141c59 in QObject::event (this=0xb93530, e=<optimized out>) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:1256
#27 0x00007ffff3aa8dcc in QApplicationPrivate::notify_helper (this=<optimized 
out>, receiver=0xb93530, e=0xeaf1f0) at 
/home/kde-devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3717
#28 0x00007ffff3aadd96 in QApplication::notify (this=0x7fffffffde60, 
receiver=0xb93530, e=0xeaf1f0) at 
/home/kde-devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3498
```


Repository: kio


Description
-------

Scheduler::jobFinished cleans up the job but doesn't report it as such.


Diffs (updated)
-----

  src/core/simplejob.cpp 3380cbe 
  autotests/jobtest.h 7641131 
  autotests/jobtest.cpp 7da92d5 

Diff: https://git.reviewboard.kde.org/r/125164/diff/


Testing
-------

Added a test and made it pass.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to