> On Okt. 17, 2016, 8:02 vorm., Aleix Pol Gonzalez wrote: > > +1 LGTM, unsure of the implications.
I would like to commit that patch after the next KF5 release to give it a full month of testing for possible side effects. If anyone objects, please raise your voice within the next 7 days. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129202/#review100066 ----------------------------------------------------------- On Okt. 16, 2016, 5:50 nachm., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129202/ > ----------------------------------------------------------- > > (Updated Okt. 16, 2016, 5:50 nachm.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Leinir Turthra > Jensen, and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Always mark a provider as initialized when all initializion steps > are performed, in particularly when an error occured. This ensures > that the UI is correctly updated when the initialization steps finished. > > > Diffs > ----- > > src/attica/atticaprovider.cpp bc590ce2a2170f69d0b6d8049f7d5da5d0c1d0cd > > Diff: https://git.reviewboard.kde.org/r/129202/diff/ > > > Testing > ------- > > manual testing > > > Thanks, > > Andreas Cord-Landwehr > >
