martinkostolny updated this revision to Diff 12058. martinkostolny added a comment. | View Revision
Next iteration, still without autotests, I need to study them more.
This diff includes preserving owner and group when file is saved with elevated privileges. Actually loosing owner was (and is) already happening before my patch when user has the permission to write the file and is not his owner. In this case, I believe we have 3 options:
- Leave it as it is
- Detect different owner and in such situation use direct writing (without QSaveFile)
- Use QSaveFile but in case of different owner ask for elevated privilege to be able to reset the owner
Is there another solution I'm missing?
PS: Regarding windows and other non-linux platforms I unfortunately cannot test the code there right now.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
REVISION DETAIL
AFFECTED FILES
src/CMakeLists.txt
src/buffer/katesecuretextbuffer.cpp
src/buffer/katesecuretextbuffer.h
src/buffer/katetextbuffer.cpp
src/buffer/org.kde.ktexteditor.katetextbuffer.actions
src/buffer/katesecuretextbuffer.cpp
src/buffer/katesecuretextbuffer.h
src/buffer/katetextbuffer.cpp
src/buffer/org.kde.ktexteditor.katetextbuffer.actions
EMAIL PREFERENCES
To: martinkostolny, dhaumann, KTextEditor
Cc: dhaumann, graesslin, davidedmundson, palant, kwrite-devel, Frameworks, head7, cullmann, kfunk, sars
Cc: dhaumann, graesslin, davidedmundson, palant, kwrite-devel, Frameworks, head7, cullmann, kfunk, sars