| martinkostolny updated this revision to Diff 12084. martinkostolny added a comment. | View Revision
After reading though bug mentioned by Luigi and this QT bug (https://bugreports.qt.io/browse/QTBUG-56366) I'm not so convinced that we want to directly write to file in order to maintain owner, because we would loose atomicity of the save operation. I've updated the diff so at least group is restored to the previous one if owner cannot be changed. I think loosing group was the most painful outcome of QSaveFile design.
Now to the autotests, I didn't make much progress, yet :). Maybe these will be a bit rookie questions but: Do you know of any KDE project I can learn from? A project with autotests that include testing KAuth action? I mean can I even test that root-owned file will only be saved with elevated privileges through KAuth action execution?
src/buffer/katesecuretextbuffer.cpp
src/buffer/katesecuretextbuffer.h
src/buffer/katetextbuffer.cpp
src/buffer/org.kde.ktexteditor.katetextbuffer.actions
Cc: ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, Frameworks, head7, cullmann, kfunk, sars
