elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed.
I spotted one small regression, I added a test case for it in https://phabricator.kde.org/R236:380b35439a39950769fcca63f7ec31cc6170707a. For manual test you can also use `tests/knewpasswordwidget_test`: - type a password - click the visibility action - make sure the second line edit gets hidden. REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: elvisangelaccio, #frameworks