mlaurent added inline comments. INLINE COMMENTS
> cfeck wrote in knewpasswordwidgettest.cpp:63 > Does using setPassword() not work for these tests? Nope as setPassword not authorize to see icon (it's a security when we setPassword from apps you don't want to see it) > cfeck wrote in knewpasswordwidget.ui:81 > Why this sizeHint? designer bug :) > cfeck wrote in kpassworddialog.ui:191 > Revert manual white-space edit. manual ? :) nope it's designer which added it > kossebau wrote in passwordlineedit.h:27 > Surprised to see no K-prefix being used here? Why that? > > Please add one and rename to `KPasswordLineEdit`: > > - for consistency with the existing classes from kwidgetaddons/kde frameworks > - to protect against potential clashes, even if rare chance, with existing > code linking to kwidgetaddons, which assumes using unprefixed/namespace-less > names is safe in own code and might use that name for something else already. > - namespace-less class name lack any hint to origin, but rather used for > project-internal code, so confuses code readers Just for info LineEditUrlDropEventFilter has not K prefix but ok I will rename it REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks
