kossebau added inline comments.
INLINE COMMENTS
> passwordlineedit.h:27
> +class PasswordLineEditPrivate;
> +class KWIDGETSADDONS_EXPORT PasswordLineEdit : public QWidget
> +{
Surprised to see no K-prefix being used here? Why that?
Please add one and rename to `KPasswordLineEdit`:
- for consistency with the existing classes from kwidgetaddons/kde frameworks
- to protect against potential clashes, even if rare chance, with existing code
linking to kwidgetaddons, which assumes using unprefixed/namespace-less names
is safe in own code and might use that name for something else already.
- namespace-less class name lack any hint to origin, but rather used for
project-internal code, so confuses code readers
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
