mwolff added inline comments.
INLINE COMMENTS
> kurlmimedata.cpp:74
> }
> QByteArray ba = mimeData->data(QString::fromLatin1(firstMimeType));
> if (ba.isEmpty()) {
if `firstMimeType == "text/uri-list"` (see above, `PreferLocalUrls`), it's
still going to be slow, no? Should this be handled generally here by
introducing a helper that checks the mime type and then uses either `urls()`
directly or call data as before?
also, what happens if `PreferLocalUrls` is set, but no `text/uri-list` data is
available, could the old way of getting the data for the `s_kdeUriListMime`
have worked more reliably?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10155
To: jtamate, #frameworks, dfaure
Cc: mwolff, michaelh
