markg added a comment.
In D12321#252259 <https://phabricator.kde.org/D12321#252259>, @anemeth wrote: > In D12321#252238 <https://phabricator.kde.org/D12321#252238>, @markg wrote: > > > You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the preview off all of a sudden?" responses which will lead to bug reports. > > > That's why the tooltip changes when that is the case. Let me rephrase it then :) The user **explicitly** clicks on the preview button. If the user then zooms in/out that same preview button might change to what the view thinks is best. That is unexpected behavior. A tri-state would prevent that. For the record, if it becomes a tri-state i would set it to auto (this implementation, the view knows best) by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns