markg added a comment.
In D12321#252282 <https://phabricator.kde.org/D12321#252282>, @rkflx wrote: > In D12321#252281 <https://phabricator.kde.org/D12321#252281>, @markg wrote: > > > I agree but not for a button that the user controls. > > > We already disable options where they do not make sense, see the Icon position setting which is only available in select view modes. > > The ability to preview could similarly be disabled where it does not make sense. I highly doubt this will cause confusion for users. Ohh, but i'm not against that :) I merely don't want one button to be changed by both the user and some code logic. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns