anthonyfieroni added inline comments.

INLINE COMMENTS

> jtamate wrote in kioexecd.cpp:65
> There is a slightly problem:  QStandardPaths::CacheLocation is application 
> dependent, and their values doesn't match here:
> kioexec: /home/jtorres/.cache/kioexec/
> kioexecd: /home/jtorres/.cache/kiod5/
> Can we assume that replacing kiod5 by kioexec will always work?
> 
> We could use QStandardPaths::GenericCacheLocation instead, but this is not 
> guaranteed to be non empty.
> 
> Or another solution: keep it as it was (delete only the file and the 
> directory if it is possible).

You can remove only file and then if dir is empty to delete it. Same in 
slotCheckDeletedFiles

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

Reply via email to