bruns added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kioexecd.cpp:134
> Also for loop should looks like:
>
> for (it = begin(); it != end();) {
> if () {
> it = erase(it);
> } else {
> ++it;
> }
> }
Even better use the std::remove_if/std::erase pattern, which avoids O(n^2)
complexity during erase.
Or in this specific case, std::partition/{iterate over removed}/std::erase
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15180
To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: bruns, anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh,
ngraham
