bruns added a comment.
In D16498#350422 <https://phabricator.kde.org/D16498#350422>, @pino wrote: > In D16498#350289 <https://phabricator.kde.org/D16498#350289>, @bruns wrote: > > > In D16498#350286 <https://phabricator.kde.org/D16498#350286>, @pino wrote: > > > > > Ugh no manual parsing of PS files -- please use libspectre. > > > > > > This is not Postscript parsing, but DSC parsing - read the specification to understand the difference! > > > > http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf > > > An EPS file //is// also a PostScript file, and indeed ghostscript opens it perfectly - also ** > Because of the above, libspectre perfectly handles EPS files, and the API already provides all the information that the current DscExtractor provides as well. Its an additional dependency (libpectre and libgs), and also imposes a security risk - see e.g. https://nvd.nist.gov/vuln/detail/CVE-2018-11645 > In D16498#350325 <https://phabricator.kde.org/D16498#350325>, @bruns wrote: > >> @pino - please remove your change request, if you have not read the code at all ... > > > Please tone down your attitude to something more respectful, thanks. You started with "Ugh ..." - you comment lacks any respect ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams