bruns marked an inline comment as done. bruns added a comment.
In D16490#351662 <https://phabricator.kde.org/D16490#351662>, @astippich wrote: > Only one minor thing: please also check that the mimetype is in the list of supported mimetypes This can actually happen and is completely valid, due to mimetype inheritance. So the check would be `for supported in supportedMimetypes { if QMimeType(input->mimeType()).inherits(supported) return true; }; return false`. But this is already done from the calling code ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
