astippich added a comment.

  In D16490#352109 <>, @bruns wrote:
  > In D16490#351935 <>, @astippich 
  > > In D16490#351799 <>, @bruns 
  > >
  > > > In D16490#351662 <>, 
@astippich wrote:
  > > >
  > > > > Only one minor thing: please also check that the mimetype is in the 
list of supported mimetypes
  > > >
  > > >
  > > > This can actually happen and is completely valid, due to mimetype 
  > > >
  > > > So the check would be `for supported in supportedMimetypes { if 
QMimeType(input->mimeType()).inherits(supported) return true; }; return false`. 
But this is already done from the calling code ...
  > >
  > >
  > > Hmmm, I don't understand. When I change the code to return an empty 
stringlist of supported mimetypes for the xmlextractor, the tests still pass.
  > >  This should imho be covered by the tests.
  > This is one level above these tests. The surrounding code ensures the right 
extractor is called for each file, see 
  Right, and if e.g. the list of supported mimetypes is empty, the 
corresponding extractor will never be selected because ExtractorCollection 
doesn't know that the mimetype is supported by this extractor.
  Hence we should ensure and test imho that the list of supported mimetypes 
provided to the ExtractorCollection is correct for this extractor. I'm not 
calling for testing that the right extractor is selected.
  > These are unit tests. The test itself is responsible to call an extractor 
with a suitable file and a matching mimetype.
  > What you are calling for are system tests.

  R286 KFileMetaData


To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

Reply via email to